Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(upload): show blob previews for .webp image uploads #13242

Merged
merged 2 commits into from
Sep 10, 2024
Merged

fix(upload): show blob previews for .webp image uploads #13242

merged 2 commits into from
Sep 10, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Sep 9, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Before 🏡 After
image image
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added 3. to review bug feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings labels Sep 9, 2024
@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Sep 9, 2024
@Antreesy Antreesy self-assigned this Sep 9, 2024
@Antreesy Antreesy marked this pull request as draft September 9, 2024 12:37
@Antreesy
fix(upload): show blob previews for .webp images
5406f55 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(upload): ignore unsupported formats of image previews
45baeac 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/12866/allow-webp-previews branch from 8435e81 to 45baeac Compare September 9, 2024 13:05
@Antreesy Antreesy requested a review from ShGKme September 9, 2024 13:07
@Antreesy
Copy link
Contributor Author

Antreesy commented Sep 9, 2024

  • Moved array to shared constants
  • Exclude unsupported image/* types from showing a preview (it's in original size, and for svg+xml and others for now - it's mimeicon 24*24 anyway)

@Antreesy Antreesy marked this pull request as ready for review September 9, 2024 13:08
@Antreesy
Copy link
Contributor Author

/backport to stable30

@Antreesy Antreesy merged commit b4fb187 into main Sep 10, 2024
48 checks passed
@Antreesy Antreesy deleted the fix/12866/allow-webp-previews branch September 10, 2024 06:41
@backportbot backportbot bot mentioned this pull request Sep 10, 2024
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.

When sending WebP images, the preview isn't loaded immediately
3 participants
@Antreesy @ShGKme @DorraJaouad