Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(call): temporary disable a call button if ended by moderator #13243

Merged
merged 2 commits into from
Sep 11, 2024
Merged

fix(call): temporary disable a call button if ended by moderator #13243

merged 2 commits into from
Sep 11, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Sep 9, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏡 After
image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Sep 9, 2024
@Antreesy Antreesy self-assigned this Sep 9, 2024
@Antreesy Antreesy changed the title fix(upload): ignore unsupported formats of image previews fix(call): temporary disable a call button if ended by moderator Sep 9, 2024
@Antreesy
Copy link
Contributor Author

  • add a watcher to reset flag on conversation switch
  • add a timediff calculation (proof from old messages as well)

DorraJaouad
DorraJaouad reviewed Sep 11, 2024
View reviewed changes
src/components/TopBar/CallButton.vue Show resolved Hide resolved
src/components/TopBar/CallButton.vue Outdated Show resolved Hide resolved
src/store/callViewStore.js Outdated Show resolved Hide resolved
DorraJaouad
DorraJaouad approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, good to go

@Antreesy
fix(call): temporary disable a call button if ended by moderator
c9420db 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Copy link
Contributor Author

/backport to stable30

@Antreesy
fix(call): don't disable a call button in 1-1 rooms, properly handle …
35c7a4c 
…timeouts

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
DorraJaouad
DorraJaouad approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes 👍🏻
Tested

@Antreesy Antreesy merged commit 7c932c8 into main Sep 11, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/8148/call-just-ended branch September 11, 2024 12:21
@backportbot backportbot bot mentioned this pull request Sep 11, 2024
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.

Disable "Start call button" when moderator ends a meeting
3 participants
@Antreesy @nickvergessen @DorraJaouad