Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate pollsStore to Pinia 🍍 #13249

Merged
merged 3 commits into from
Sep 14, 2024
Merged

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Sep 10, 2024

β˜‘οΈ Resolves

πŸ–ŒοΈ UI Checklist

no visual changes

🚧 Tasks

  • Write tests
  • Migrate to TS (follow-up)
  • Migrate pollService to TS (follow-up)

🏁 Checklist

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy marked this pull request as ready for review September 11, 2024 09:12
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good πŸ¦…, tested βœ…

src/stores/__tests__/polls.spec.js Outdated Show resolved Hide resolved
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy merged commit dd61c8e into main Sep 14, 2024
46 checks passed
@Antreesy Antreesy deleted the feat/noid/pollstore-to-pinia branch September 14, 2024 12:07
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants