chore(SettingsAPI): replace reactive with ref to remove Vue 2 warn #13266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii K. Shartsev <me@shgk.me> Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
chore/shallow-reactive-array-warn
branch
from
0b58e7a
to
b991291
Compare
Antreesy
approved these changes
Sep 11, 2024
DorraJaouad
approved these changes
Sep 11, 2024
|
/backport to stable30 |
ShGKme
commented
Sep 11, 2024
Comment on lines
+26
to
+27
| // TODO: use shallowReactive instead of ref + markRaw in Vue 3 (see file commit history) | ||
| const customSettingsSections: Ref<TalkSettingsSection[]> = ref([]) |
There was a problem hiding this comment.
shallowReactive has no real advantages except that it allows to get rid of markRaw in just one function.
There was a problem hiding this comment.
which still isn't bad, i think
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes nothing in how it works.
Gets rid of the annoying Vue 2 warning about
reactive(array)behavior on Vue 2 vs Vue 3 inwatch(which we even don't use).