Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(widget): allow to show file share as widget if possible #13271

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Allows to show interactive widget if internal link is available

🖌️ UI Checklist

2024-09-11_16h21_14.mp4

🚧 Tasks

  • ...

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@marcoambrosini
Copy link
Member

@Antreesy would interadcive widget be disabled by default then?

@Antreesy
Copy link
Contributor Author

Antreesy commented Sep 14, 2024

would interactive widget be disabled by default then?

No, that's different) Currently:

  • if you share a file, we show only a file preview;
  • if you post an internal link, we show an interactive widget embedded;

This PR allows to toggle file share preview <=> embedded widget on user demand.
So if you share a link, there is no way to turn widget into static preview

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this I would add a button close to the preview. Using something like this as icon.

https://fonts.google.com/icons?selected=Material+Symbols+Outlined:expand_content:FILL@0;wght@400;GRAD@0;opsz@24&icon.query=open&icon.size=24&icon.color=%235f6368

Ideally somewhere where it stays on the same place, so that I can quickly expand and collapse the view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants