fix(navbar): shouldHideOnScroll fixed (#3315)

* fix(navbar): shouldHideOnScroll fixed * Update packages/hooks/use-scroll-position/src/index.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update index.ts * fix(navbar): applying suggested changes --------- Co-authored-by: Pratyush <conenct2pratyush@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
nextui-org · Jul 6, 2024 · 35e709d · 35e709d
1 parent 444d320
commit 35e709d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/happy-cameras-whisper.md b/.changeset/happy-cameras-whisper.md
@@ -0,0 +1,5 @@
+---
+"@nextui-org/use-scroll-position": patch
+---
+
+clearing throttleTimeout when it is supposed to be null in useScrollPosition (#3139)
diff --git a/packages/hooks/use-scroll-position/src/index.ts b/packages/hooks/use-scroll-position/src/index.ts
@@ -59,9 +59,11 @@ export const useScrollPosition = (props: UseScrollPositionOptions): ScrollValue
 
     const handleScroll = () => {
       if (delay) {
-        if (throttleTimeout.current === null) {
-          throttleTimeout.current = setTimeout(handler, delay);
+        if (throttleTimeout.current) {
+          clearTimeout(throttleTimeout.current);
         }
+
+        throttleTimeout.current = setTimeout(handler, delay);
       } else {
         handler();
       }