Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1298 #1542

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Fix/1298 #1542

merged 2 commits into from
Sep 1, 2023

Conversation

jrgarciadev
Copy link
Member

Closes #1298

📝 Description

Navbar Menu lacks focus trapping

⛳️ Current behavior (updates)

Navbar Menu lacks focus trapping

🚀 New behavior

Dismissable buttons added to trap navbar menu focus

💣 Is this a breaking change (Yes/No): No

📝 Additional Information

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2023

🦋 Changeset detected

Latest commit: 7f3c242

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@nextui-org/navbar Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nextui-docs-v2 ❌ Failed (Inspect) Sep 1, 2023 8:28pm
nextui-storybook-v2 ❌ Failed (Inspect) Sep 1, 2023 8:28pm

@jrgarciadev jrgarciadev merged commit 57909ac into main Sep 1, 2023
6 of 8 checks passed
@jrgarciadev jrgarciadev deleted the fix/1298 branch September 1, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - 2.0 NavbarMenu lacks focus trapping
1 participant