Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1531 #1545

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Fix/1531 #1545

merged 2 commits into from
Sep 1, 2023

Conversation

jrgarciadev
Copy link
Member

Closes #1531

📝 Description

Tab passes the title to the HTML element which lead to render [Object object] values

⛳️ Current behavior (updates)

Tab passes the title to the HTML element

🚀 New behavior

New prop added to Tab items titleValue which allows users pass the nativetitle prop to the HTML element, original title was removed from the list of valid properties.

💣 Is this a breaking change (Yes/No): NO

📝 Additional Information

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2023

🦋 Changeset detected

Latest commit: 7bff1b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@nextui-org/tabs Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 8:40pm
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 8:40pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - When the title prop of Tab is not a string, it should not be passed to HTML elements.
1 participant