-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: optimisations #3523
base: canary
Are you sure you want to change the base?
refactor: optimisations #3523
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: a0b0684 The changes in this PR will be included in the next version bump. This PR includes changesets to release 52 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Closes #
📝 Description
(1) replace lodash with native approaches
(2) framer motion
usedomAnimation
instead ofdomMax
in Tabs componentAffected components:
Unchanged components:
For tabs component, we need to use
domMax
to achieve the shifting when switching between tabs. We cannot use dynamic load here as it fails sometimes, e.g. the animation will be gone sometimes. probably a bug in framer-motion.⛳️ Current behavior (updates)
vite-template + 8 above-mentioned components
🚀 New behavior
vite-template + 8 above-mentioned components
/doc
includes the above-mentioned 8 components that use LazyMotion.💣 Is this a breaking change (Yes/No):
No
📝 Additional Information