Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimisations #3523

Draft
wants to merge 12 commits into
base: canary
Choose a base branch
from
Draft

refactor: optimisations #3523

wants to merge 12 commits into from

Conversation

wingkwong
Copy link
Member

@wingkwong wingkwong commented Jul 21, 2024

Closes #

📝 Description

(1) replace lodash with native approaches

  • replaced most lodash usages with native approaches.

(2) framer motion

  • upgrade framer-motion versions
  • reduce bundle size
  • load domAnimation dynamically
  • use domAnimation instead of domMax in Tabs component

Affected components:

  • accordion
  • calendar
  • modal
  • navbar
  • popover
  • ripple
  • tooltip

Unchanged components:

  • tabs

For tabs component, we need to use domMax to achieve the shifting when switching between tabs. We cannot use dynamic load here as it fails sometimes, e.g. the animation will be gone sometimes. probably a bug in framer-motion.

⛳️ Current behavior (updates)

vite-template + 8 above-mentioned components

dist/index.html                     0.97 kB │ gzip:   0.46 kB
dist/assets/favicon-DI5FVxIz.ico   15.09 kB
dist/assets/index-DhrH5Nzw.css    215.57 kB │ gzip:  23.66 kB
dist/assets/index-32UuhZvQ.js     916.79 kB │ gzip: 292.41 kB

🚀 New behavior

vite-template + 8 above-mentioned components

dist/index.html                     0.97 kB │ gzip:   0.46 kB
dist/assets/favicon-DI5FVxIz.ico   15.09 kB
dist/assets/index-DhrH5Nzw.css    215.57 kB │ gzip:  23.66 kB
dist/assets/index-CAu8Gkyy.js      57.71 kB │ gzip:  20.37 kB
dist/assets/index-C3R4YDRP.js     855.12 kB │ gzip: 269.47 kB
  • left: before, right: after (initial load time has been reduced)
  • /doc includes the above-mentioned 8 components that use LazyMotion.

image

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Copy link

vercel bot commented Jul 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 8:33am
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 8:33am

Copy link

changeset-bot bot commented Jul 21, 2024

🦋 Changeset detected

Latest commit: a0b0684

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 52 packages
Name Type
@nextui-org/calendar Patch
@nextui-org/theme Patch
@nextui-org/use-infinite-scroll Patch
@nextui-org/shared-utils Patch
@nextui-org/accordion Patch
@nextui-org/modal Patch
@nextui-org/navbar Patch
@nextui-org/popover Patch
@nextui-org/ripple Patch
@nextui-org/tooltip Patch
@nextui-org/dom-animation Patch
@nextui-org/autocomplete Patch
@nextui-org/button Patch
@nextui-org/card Patch
@nextui-org/dropdown Patch
@nextui-org/select Patch
@nextui-org/snippet Patch
@nextui-org/tabs Patch
@nextui-org/system Patch
@nextui-org/framer-utils Patch
@nextui-org/date-picker Patch
@nextui-org/react Patch
@nextui-org/avatar Patch
@nextui-org/badge Patch
@nextui-org/breadcrumbs Patch
@nextui-org/checkbox Patch
@nextui-org/chip Patch
@nextui-org/code Patch
@nextui-org/date-input Patch
@nextui-org/divider Patch
@nextui-org/image Patch
@nextui-org/input Patch
@nextui-org/kbd Patch
@nextui-org/link Patch
@nextui-org/listbox Patch
@nextui-org/menu Patch
@nextui-org/pagination Patch
@nextui-org/progress Patch
@nextui-org/radio Patch
@nextui-org/scroll-shadow Patch
@nextui-org/skeleton Patch
@nextui-org/slider Patch
@nextui-org/spacer Patch
@nextui-org/spinner Patch
@nextui-org/switch Patch
@nextui-org/table Patch
@nextui-org/user Patch
@nextui-org/use-data-scroll-overflow Patch
@nextui-org/use-pagination Patch
@nextui-org/aria-utils Patch
@nextui-org/react-utils Patch
@nextui-org/use-real-shape Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wingkwong wingkwong added this to the v2.5.0 milestone Jul 21, 2024
Copy link
Contributor

coderabbitai bot commented Jul 21, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant