-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(date-picker): adding props from calendarProps to the getCalendarProps #3773
base: canary
Are you sure you want to change the base?
fix(date-picker): adding props from calendarProps to the getCalendarProps #3773
Conversation
🦋 Changeset detectedLatest commit: 7f2fbe4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Someone is attempting to deploy a commit to the NextUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThis update introduces a patch for the Changes
Assessment against linked issues
Possibly related PRs
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (2)
Additional comments not posted (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Closes #3769
📝 Description
⛳️ Current behavior (updates)
So currently, the classNames in calendarProps are not propagated to the Calendar due to which the styling does not get applied.
As of now, adding the above prop to the date-picker gives following result (does not apply the mentioned style to the grid i.e.
bg-red-800
):🚀 New behavior
The PR propagates the calendarProps's classNames so that styling do get apply to them.
After the changes in this PR, adding the above prop to the date-picker gives following result (applies the mentioned styling to the grid i.e.
bg-red-800
):💣 Is this a breaking change (Yes/No): No
Summary by CodeRabbit
New Features
Bug Fixes