Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update igenomes config #77

Merged
merged 14 commits into from
Sep 27, 2023
Merged

Update igenomes config #77

merged 14 commits into from
Sep 27, 2023

Conversation

nictru
Copy link
Contributor

@nictru nictru commented Sep 25, 2023

I updated the igenomes config because there were some issues concerning null values when using igenomes, probably because some of the attributes were missing in the old version

There are some other things fixed:

  • Version dumping failed because of unexpected indentation
  • Pipeline parameters were overwritten by the default values when set via igenomes
  • Linting errors

@nictru
Copy link
Contributor Author

nictru commented Sep 26, 2023

I figured out that removing the gtf default value was not the smartest idea, since the nf-core linting is failing now. I'll have a second look at this.

@maxulysse
Copy link
Member

I feel that you have a template update at the same time.
Can you have a look at #78 before?

@nictru
Copy link
Contributor Author

nictru commented Sep 26, 2023

Thanks for the hint @maxulysse. I rebased #78 so that we can merge that one first.

@maxulysse
Copy link
Member

Thanks for the hint @maxulysse. I rebased #78 so that we can merge that one first.

sorry, read the other PR before...
Figured you wanted to merge #78 and then use #77 to fix the tests, not the other way around..

🤦

@nictru
Copy link
Contributor Author

nictru commented Sep 26, 2023

Finally everything should be ready now.

@nictru nictru mentioned this pull request Sep 26, 2023
conf/test_cache.config Outdated Show resolved Hide resolved
main.nf Show resolved Hide resolved
Copy link

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@nictru nictru merged commit 0eacfcf into dev Sep 27, 2023
6 checks passed
@nictru nictru deleted the update-igenomes branch September 27, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not a valid path value: 'null'
3 participants