fix: prevent opening form popup through detail popup when it is disabled #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heenakwag
approved these changes
Aug 16, 2022
lja1018
approved these changes
Aug 16, 2022
| popupArrowPointPosition, | ||
| }); | ||
| } else { | ||
| eventBus.fire('beforeUpdateEvent', { event: event.toEventObject(), changes: {} }); |
There was a problem hiding this comment.
beforeUpdateEvent 커스텀이벤트는 뭔가 이벤트를 실제로 수정할 때 일어나야할 것 같은데 Edit 버튼을 누르면 changes 없이 이벤트가 발생하는게 조금 어색하게 느껴집니다. 어떻게 생각하시나요?
There was a problem hiding this comment.
일단 지금 코드는 v1 동작과 동일한 상태입니다.
제안한대로 수정하려면 저는 인스턴스 이벤트가 새로 추가되어야한다고 봐서, 최대한 변경을 적게 만들었어요.
changes 도 옵셔널로 만들까 했는데 그러면 신경써야할게 너무 많아서 그냥 빈 객체를 전달하는거로 바꿨습니다.
jwlee1108
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
Fixed that the default form popup appears even though the
useFormPopupoption is disabled. because theEventDetailPopupcomponent is calling it ignoring the option.Resolves #1249.
AS-IS
Screen.Recording.2022-08-12.at.16.10.26.mov
TO-BE
Screen.Recording.2022-08-12.at.16.11.51.mov
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨