Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a 'Code Example' section to the main README.md file #89

Closed
wants to merge 2 commits into from
Closed

Adds a 'Code Example' section to the main README.md file #89

wants to merge 2 commits into from

Conversation

v-antech
Copy link

@v-antech v-antech commented Mar 1, 2018

The code example section explains briefly how to set things up for
new projects and shows one way of using the i18n capabilities of
this project.

The code example section explains briefly how to set things up for
new projects and shows one way of using the i18n capabilities of
this project.
@v-antech
Copy link
Author

v-antech commented Apr 4, 2018

The month has passed, the winter is now gone from this hemisphere despite the warnings and tidings from Winterfell. Yet this pull request still persists and casts a dark shadow over the i(2*9)n GOrizon.

Hereby I officially submit a ping to the great master(s) owning this repository. Oh, great master(s), please deem this small and insignificant change worthy of your attention and don't cast it away like a wary code traveler in the days of the source.

Copy link
Owner

@nicksnyder nicksnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR to add more documentation. There are a few wording changes that I would want to make before merging this, but I have been prioritizing working on v2 of this library that will significantly change the API.

@v-antech
Copy link
Author

v-antech commented Apr 9, 2018

Ok, thanks for the reply - it is nice to hear that this library is actively being worked on :)

@nicksnyder
Copy link
Owner

Going to close this. You can see the updates that make this documentation obsolete in #92

@nicksnyder nicksnyder closed this Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants