Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7.0] [graphical/UI] Scaling of additional graph may need improvement #2

Closed
mSternEU opened this issue Sep 24, 2020 · 2 comments
Closed

Comments

@mSternEU
Copy link

mSternEU commented Sep 24, 2020

Reposting from https://github.com/MilosKozak/AndroidAPS/issues/2980#issue-708285027

Btw, master build via github/nightscout appears as '2.7.0-dev' in about-section
//edit: this part above is solved/explained by first comment

The scaling of fresh additional graphs seem to depend on the first data source selected. For full graph functionality a pre-check before drawing would be required, to find the optimal scaling.

Example/Reproduction:
Create an empty graph and use COB and DEV as data. As COB is the first source, the graph will use a fixed scaling with positive numbers only, even though DEV would need negative values.
It also affects the deviation-slope in negative area. They always work stand-alone, but in combination with COB as first source, the graph is not optimized.
When no COBs are found to be displayed for the chosen timeframe, the graph stays blank completely (like in the picture).

Screenshot_20200918-093107_AndroidAPS

@dlvoy
Copy link
Contributor

dlvoy commented Sep 24, 2020

-dev suffix is only at tag 2.7.0, master branch (one commit later) have it fixed

@mSternEU
Copy link
Author

Not fixable at current state.

kalleelmer referenced this issue in kalleelmer/AndroidAPS Oct 6, 2020
kalleelmer referenced this issue in kalleelmer/AndroidAPS Oct 6, 2020
kalleelmer referenced this issue in kalleelmer/AndroidAPS Oct 6, 2020
AdrianLxM pushed a commit that referenced this issue Nov 29, 2020
MilosKozak pushed a commit that referenced this issue Dec 7, 2020
MilosKozak pushed a commit that referenced this issue Jan 15, 2021
merge from nightscout dev
MilosKozak added a commit that referenced this issue Feb 2, 2021
MilosKozak pushed a commit that referenced this issue Feb 20, 2021
getting latest dev updates from master dev
MilosKozak pushed a commit that referenced this issue Sep 29, 2021
MilosKozak added a commit that referenced this issue Nov 30, 2021
MilosKozak added a commit that referenced this issue Jun 17, 2022
dc00l pushed a commit to dc00l/AndroidAPS that referenced this issue Jun 19, 2022
dc00l pushed a commit to dc00l/AndroidAPS that referenced this issue Jun 19, 2022
MilosKozak added a commit that referenced this issue Jan 4, 2023
MilosKozak added a commit that referenced this issue Jan 13, 2023
MilosKozak added a commit that referenced this issue Sep 3, 2023
MilosKozak added a commit that referenced this issue Nov 1, 2023
MilosKozak added a commit that referenced this issue Nov 26, 2023
MilosKozak added a commit that referenced this issue Nov 29, 2023
jakobheyman pushed a commit to jakobheyman/aapsJH that referenced this issue May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants