Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify SMB and DynISF #3157

Merged
merged 22 commits into from
Jan 24, 2024
Merged

Unify SMB and DynISF #3157

merged 22 commits into from
Jan 24, 2024

Conversation

MilosKozak
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 758 lines in your changes are missing coverage. Please review.

Comparison is base (00ae71e) 26.29% compared to head (9fa2a9b) 26.02%.
Report is 4 commits behind head on dev.

Files Patch % Lines
.../app/aaps/core/objects/aps/DetermineBasalResult.kt 41.17% 102 Missing and 38 partials ⚠️
...pp/aaps/plugins/aps/openAPSAMA/OpenAPSAMAPlugin.kt 2.83% 103 Missing ⚠️
...pp/aaps/plugins/aps/openAPSSMB/OpenAPSSMBPlugin.kt 53.65% 77 Missing and 18 partials ⚠️
...ain/kotlin/app/aaps/plugins/aps/OpenAPSFragment.kt 0.00% 34 Missing ⚠️
...ins/sync/wear/wearintegration/DataHandlerMobile.kt 0.00% 25 Missing ⚠️
...abase/persistence/converters/APSResultExtension.kt 48.64% 8 Missing and 11 partials ⚠️
.../aaps/implementation/alerts/LocalAlertUtilsImpl.kt 5.26% 17 Missing and 1 partial ⚠️
...n/app/aaps/plugins/main/profile/ProfileFragment.kt 0.00% 18 Missing ⚠️
...aaps/workflow/PrepareIobAutosensGraphDataWorker.kt 37.93% 16 Missing and 2 partials ⚠️
...p/aaps/plugins/aps/openAPSSMB/DetermineBasalSMB.kt 78.08% 6 Missing and 10 partials ⚠️
... and 75 more
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #3157      +/-   ##
============================================
- Coverage     26.29%   26.02%   -0.28%     
+ Complexity     6308     6228      -80     
============================================
  Files          2421     2410      -11     
  Lines        119560   118402    -1158     
  Branches      16457    16319     -138     
============================================
- Hits          31437    30811     -626     
+ Misses        85269    84853     -416     
+ Partials       2854     2738     -116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

5.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@MilosKozak MilosKozak merged commit 3fb5d6a into dev Jan 24, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant