Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore prediction colors in wear graph #3189

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Restore prediction colors in wear graph #3189

merged 1 commit into from
Jan 24, 2024

Conversation

Philoul
Copy link
Contributor

@Philoul Philoul commented Jan 24, 2024

Fix #3182

Note: I duplicated (with a slight adaptation) the predictionColor function included in the GlucoseValueDataPoint.kt class.
This seemed simpler to me than including a dependency to be able to import GlucoseValueDataPoint or moving this class elsewhere to avoid code redundancy.

I think it's better to keep colored prediction lines in wear graphs...

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

20 Security Hotspots
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@Philoul Philoul changed the base branch from master to dev January 24, 2024 21:07
@MilosKozak MilosKozak merged commit 1846b98 into nightscout:dev Jan 24, 2024
0 of 3 checks passed
@Philoul Philoul deleted the Fix/WearPredictions branch January 25, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DEV] Prediction curves are missing color in Wear watchfaces
2 participants
@Philoul @MilosKozak