Allow for recordOnly bolus when pump is disconnected or suspended #3254
Conversation
|
Tested with ComboV2, works well. Thanks! |
|
I generally have nothing against but it must visible on first sight that is record only. Maybe even on icon. Otherwise it can lead to mistakes. |
For example the text / checkbox "do not bolus ..." could be red?! |
Currently upon entering the bolus, it is clearly stated in the confirmation screen.
|
|
Based on what I see on my daughter, nobody reads |
Something like this? |
| @@ -583,8 +583,22 @@ class OverviewFragment : DaggerFragment(), View.OnClickListener, OnLongClickList | |||
| && preferences.get(BooleanKey.OverviewShowTreatmentButton)).toVisibility() | |||
| binding.buttonsLayout.wizardButton.visibility = (!loop.isDisconnected && pump.isInitialized() && !pump.isSuspended() && profile != null | |||
| && preferences.get(BooleanKey.OverviewShowWizardButton)).toVisibility() | |||
| binding.buttonsLayout.insulinButton.visibility = (!loop.isDisconnected && pump.isInitialized() && !pump.isSuspended() && profile != null | |||
| && preferences.get(BooleanKey.OverviewShowInsulinButton)).toVisibility() | |||
| binding.buttonsLayout.insulinButton.visibility = (profile != null && preferences.get(BooleanKey.OverviewShowInsulinButton)).toVisibility() | |||
There was a problem hiding this comment.
.toVisibility() should not be there
There was a problem hiding this comment.
I see it's on more places here
There was a problem hiding this comment.
Its needed here because:
Type mismatch.
Required:
Int
Found:
Boolean
There was a problem hiding this comment.
sorry, my mistake. There is a bracket I didn't see
|
Thumbs up from me :) I actually thought about this myself one day as we disconnect pump when in the swimming pool! Small "bug", when pump is connected (tested with virtual pump) text color of "Insulin" is white instead of blue like in dev/master. |
Thx, fixed |
|
|
This feature was high on my list: |
This PR allows to record a bolus using the Insulin button when loop is disconnected or pump is suspended/not active
Have seen this request on discord some time ago, and experienced it myself.
Consider following scenarios:
There are other scenarios as well when you want to do a pen bolus while disconnected.
Tested:
Update:
