Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix light theme in pump drivers #3258

Merged
merged 4 commits into from
Mar 10, 2024

Conversation

jbr7rr
Copy link

@jbr7rr jbr7rr commented Mar 8, 2024

Various pump drivers had their text colors hardcoded to white.

This PR fixes that.

Medtrum: Fully tested
EOPatch: Overview Tested (nothing else changed)
Equil: Overview tested, Changing of text color not tested as I dont have equil
Combo: Not tested, I dont have a combo

For combo and Equil I have requested a test on the respective channels on discord

@jbr7rr jbr7rr force-pushed the fix-light-theme-in-pump-drivers branch from 0d28a4a to 2b993aa Compare March 8, 2024 20:29
Copy link

sonarcloud bot commented Mar 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@MilosKozak MilosKozak merged commit 15260a8 into nightscout:dev Mar 10, 2024
0 of 3 checks passed
@jbr7rr jbr7rr deleted the fix-light-theme-in-pump-drivers branch March 10, 2024 16:10
@jbr7rr jbr7rr mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants