Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wear Plugin Add button to access to Exchange site for cwf in doc #3273

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

Philoul
Copy link
Contributor

@Philoul Philoul commented Mar 19, 2024

Button "Set Default" within Wear plugin replaced by button "More watchfaces" to have direct access to exchange site within documentation.

image

image

Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
25 Security Hotspots
D Reliability Rating on New Code (required ≥ A)
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@@ -203,6 +203,7 @@
<string name="wear_infos_watchface">Infos Watchface</string>
<string name="wear_export_watchface">Export template</string>
<string name="wear_new_custom_watchface_exported">Custom watchface template exported</string>
<string name="wear_link_to_more_cwf_doc">https://androidaps.readthedocs.io/en/latest/ExchangeSiteCustomWatchfaces/index.html</string>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set translatable to false, so we don't have to copy this in crowdin :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept the link translatable to be able to replace the "/en/" by language code within crowdin and then access to the "translated" exchange page within doc.

@MilosKozak MilosKozak merged commit 5b13a68 into nightscout:dev Mar 20, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants