ComboV2 fixes for duration parsing, and small bolus delivery improvements #3314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Rafael Giani <crg7475@mailbox.org>
This allows for reusing the mode in other parsers.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes duration parsing by adding a dedicated DurationParser class. This is important, because the text "24:00" is invalid for a timestamp, but valid for a duration. Fixes #3304
Also, now, during a bolus delivery, the CMD_PING based heartbeat is disabled, since it is unnecessary. It might have even triggered some race conditions inside the Combo, causing #3309 , though this is uncertain.