Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange buttons in actions tab to save screen space #3337

Merged
merged 1 commit into from
May 16, 2024

Conversation

olorinmaia
Copy link
Contributor

When using pump Omnipod Dash (without battery/priming need) the action tab look like this now:
image

This PR will change it so that there will be less scrolling in action tab and look like this:
image

For pumps with battery/priming it will look like this.
Before:
image

After:
image

@kenzo44
Copy link
Contributor

kenzo44 commented May 14, 2024

Maybe move the sensor info section to the top so the profile switch buttons are reachable

@olorinmaia
Copy link
Contributor Author

olorinmaia commented May 14, 2024

Maybe move the sensor info section to the top so the profile switch buttons are reachable

Edit @kenzo44 showed a picture at Discord of what he meant. I think this is a better arrangement of the action tab with sensor info etc at top. I can modify PR to this arrangement if no other suggestions?

image

@MilosKozak MilosKozak merged commit eb3fa57 into nightscout:dev May 16, 2024
0 of 2 checks passed
@olorinmaia olorinmaia deleted the rearrange_icons_action_tab branch June 4, 2024 23:47
@vanelsberg
Copy link
Contributor

Hmmm.... Personally, I can live with it but I'd favor current UI layout over this PR.
Also agree with @MilosKozak remarking the info section was designed to be near the Careportal section.

(btw: does the solution actually match the PR's objective as suggested by its title? For saving screen space I's more expect changing button size?)

@olorinmaia
Copy link
Contributor Author

This PR simply rearranged the order of buttons to save screen space. It doesn't move the sensor/pump info section.

Without this pr you need to scroll to reach all buttons on my phone, so imo it does what title suggest 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants