Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Graph menu + Scale menu #3347

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Conversation

Philoul
Copy link
Contributor

@Philoul Philoul commented May 24, 2024

Final proposal for Graph and Scale menu (replace #3306 and #3311)
See below screenshots of UI proposal for Graph settings and new menu for Scale
image

@vanelsberg
Copy link
Contributor

vanelsberg commented May 24, 2024

Thanks, well done!
Merges builds fine with current dev. all as expected!

Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
25 Security Hotspots
C Security Rating on New Code (required ≥ A)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@MilosKozak
Copy link
Contributor

is it still disabled to select the same graph multiple times? @Philoul

@Philoul
Copy link
Contributor Author

Philoul commented Aug 2, 2024

Yes,
I used checkboxes but they works close to radiobuttons on each row...
If you want to move a curve from one subgraph to a new one, you just click on the new corresponding column and previous one will be disabled.
(I selected a checkbox because you can disabled a curve with nothing checked on one row, it's not possible with radiobuttons)

@MilosKozak MilosKozak merged commit 39752d7 into nightscout:dev Aug 2, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants