-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added missing
isVisible
command in new Element API (#4039)
Co-authored-by: Priyansh Garg <priyanshgarg30@gmail.com>
- Loading branch information
1 parent
4ac5131
commit 9514af4
Showing
5 changed files
with
189 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/** | ||
* Determines if an element is visible. | ||
* | ||
* For more info on working with DOM elements in Nightwatch, refer to the <a href="https://nightwatchjs.org/guide/writing-tests/finding-interacting-with-dom-elements.html">Finding & interacting with DOM Elements</a> guide page. | ||
* | ||
* @example | ||
* describe('isVisible demo', function() { | ||
* it('test isVisible', function(browser) { | ||
* browser.element('#search').isVisible().assert.equals(true); | ||
* }); | ||
* | ||
* it('test async isVisible', async function(browser) { | ||
* const result = await browser.element('#search').isVisible(); | ||
* browser.assert.equal(result, true); | ||
* }); | ||
* }); | ||
* | ||
* @since 3.5.0 | ||
* @method isVisible | ||
* @memberof ScopedWebElement | ||
* @instance | ||
* @syntax browser.element(selector).isVisible() | ||
* @see https://www.w3.org/TR/webdriver/#element-displayedness | ||
* @returns {ScopedValue<boolean>} | ||
* @alias isDisplayed | ||
*/ | ||
module.exports.command = function() { | ||
return this.runQueuedCommandScoped('isElementDisplayed'); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,150 @@ | ||
const assert = require('assert'); | ||
const {WebElement} = require('selenium-webdriver'); | ||
const MockServer = require('../../../../lib/mockserver.js'); | ||
const CommandGlobals = require('../../../../lib/globals/commands-w3c.js'); | ||
const common = require('../../../../common.js'); | ||
const Element = common.require('element/index.js'); | ||
|
||
describe('element().isVisible() command', function() { | ||
before(function (done) { | ||
CommandGlobals.beforeEach.call(this, done); | ||
}); | ||
|
||
after(function (done) { | ||
CommandGlobals.afterEach.call(this, done); | ||
}); | ||
|
||
it('test .element().isVisible() displayed', async function() { | ||
let elementId; | ||
|
||
MockServer.addMock({ | ||
url: '/session/13521-10219-202/execute/sync', | ||
method: 'POST', | ||
response: JSON.stringify({ | ||
value: true | ||
}), | ||
onRequest(_, requestData) { | ||
elementId = requestData.args[0]['element-6066-11e4-a52e-4f735466cecf']; | ||
} | ||
}, true); | ||
|
||
const resultPromise = this.client.api.element('#signupSection').isVisible(); | ||
assert.strictEqual(resultPromise instanceof Element, false); | ||
assert.strictEqual(typeof resultPromise.find, 'undefined'); | ||
|
||
assert.strictEqual(resultPromise instanceof Promise, false); | ||
assert.strictEqual(typeof resultPromise.then, 'function'); | ||
|
||
const result = await resultPromise; | ||
assert.strictEqual(result instanceof WebElement, false); | ||
assert.strictEqual(result, true); | ||
assert.strictEqual(elementId, '0'); | ||
}); | ||
|
||
it('test .element().isVisible() not displayed', async function() { | ||
let elementId; | ||
|
||
MockServer.addMock({ | ||
url: '/session/13521-10219-202/execute/sync', | ||
method: 'POST', | ||
response: JSON.stringify({ | ||
value: false | ||
}), | ||
onRequest(_, requestData) { | ||
elementId = requestData.args[0]['element-6066-11e4-a52e-4f735466cecf']; | ||
} | ||
}, true); | ||
|
||
const resultPromise = this.client.api.element('#signupSection').isVisible(); | ||
assert.strictEqual(resultPromise instanceof Element, false); | ||
assert.strictEqual(typeof resultPromise.find, 'undefined'); | ||
|
||
assert.strictEqual(resultPromise instanceof Promise, false); | ||
assert.strictEqual(typeof resultPromise.then, 'function'); | ||
|
||
const result = await resultPromise; | ||
assert.strictEqual(result instanceof WebElement, false); | ||
assert.strictEqual(result, false); | ||
assert.strictEqual(elementId, '0'); | ||
}); | ||
|
||
it('test .element().find().isVisible()', async function() { | ||
let elementId; | ||
|
||
MockServer.addMock({ | ||
url: '/session/13521-10219-202/execute/sync', | ||
method: 'POST', | ||
response: JSON.stringify({ | ||
value: true | ||
}), | ||
onRequest(_, requestData) { | ||
elementId = requestData.args[0]['element-6066-11e4-a52e-4f735466cecf']; | ||
} | ||
}, true); | ||
|
||
const resultPromise = this.client.api.element('#signupSection').find('#helpBtn').isVisible(); | ||
assert.strictEqual(resultPromise instanceof Element, false); | ||
assert.strictEqual(typeof resultPromise.find, 'undefined'); | ||
|
||
assert.strictEqual(resultPromise instanceof Promise, false); | ||
assert.strictEqual(typeof resultPromise.then, 'function'); | ||
|
||
const result = await resultPromise; | ||
assert.strictEqual(result instanceof WebElement, false); | ||
assert.strictEqual(result, true); | ||
assert.strictEqual(elementId, '1'); | ||
}); | ||
|
||
it('test .element.find().isVisible() not displayed', async function() { | ||
let elementId; | ||
|
||
MockServer.addMock({ | ||
url: '/session/13521-10219-202/execute/sync', | ||
method: 'POST', | ||
response: JSON.stringify({ | ||
value: false | ||
}), | ||
onRequest(_, requestData) { | ||
elementId = requestData.args[0]['element-6066-11e4-a52e-4f735466cecf']; | ||
} | ||
}, true); | ||
|
||
const resultPromise = this.client.api.element.find('#signupSection').isVisible(); | ||
assert.strictEqual(resultPromise instanceof Element, false); | ||
assert.strictEqual(typeof resultPromise.find, 'undefined'); | ||
|
||
assert.strictEqual(resultPromise instanceof Promise, false); | ||
assert.strictEqual(typeof resultPromise.then, 'function'); | ||
|
||
const result = await resultPromise; | ||
assert.strictEqual(result instanceof WebElement, false); | ||
assert.strictEqual(result, false); | ||
assert.strictEqual(elementId, '0'); | ||
}); | ||
|
||
it('test .element().isVisible() assert', async function() { | ||
let elementId; | ||
|
||
MockServer.addMock({ | ||
url: '/session/13521-10219-202/execute/sync', | ||
method: 'POST', | ||
response: JSON.stringify({ | ||
value: true | ||
}), | ||
onRequest(_, requestData) { | ||
elementId = requestData.args[0]['element-6066-11e4-a52e-4f735466cecf']; | ||
} | ||
}, true); | ||
|
||
const resultPromise = this.client.api.element('#signupSection').isVisible(); | ||
assert.strictEqual(resultPromise instanceof Element, false); | ||
assert.strictEqual(typeof resultPromise.find, 'undefined'); | ||
|
||
assert.strictEqual(resultPromise instanceof Promise, false); | ||
assert.strictEqual(typeof resultPromise.then, 'function'); | ||
|
||
assert.strictEqual(await resultPromise.assert.equals(true), true); | ||
assert.strictEqual(await resultPromise.assert.not.equals(false), true); | ||
assert.strictEqual(elementId, '0'); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters