Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions.session() and Actions.sessions() issue #287

Closed
afruth opened this issue Oct 7, 2014 · 0 comments
Closed

Actions.session() and Actions.sessions() issue #287

afruth opened this issue Oct 7, 2014 · 0 comments

Comments

@afruth
Copy link

afruth commented Oct 7, 2014

https://github.com/beatfactor/nightwatch/blob/master/lib/selenium/protocol.js

I believe that Actions.sessions() method should point to the /sessions endpoint instead of /session.

Also, the /session GET action should point to the /session/:sessionId endpoint, as it is now it throws an error.

As a suggestion maybe add the POST action in /session too (without sessionId) as per Selenium docs? https://code.google.com/p/selenium/wiki/JsonWireProtocol#/session

Keep up the good work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants