Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix element lookup with reference to a shadow root. #3992

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Fix element lookup with reference to a shadow root. #3992

merged 4 commits into from
Jan 24, 2024

Conversation

garg3133
Copy link
Member

@garg3133 garg3133 commented Jan 15, 2024 •
edited
Loading

Instead of calling .findElements() directly on parentElement.webElement (which is always a WebElementPromise due to which .findElement() method on it will always hit /elements/:elementId/elements endpoint), we first resolve parentElement.webElement promise in this PR to get a corresponding instance of WebElement or ShadowRoot and then apply .findElements() on top of the actual result.

Fixes: #3989

@github-actions GitHub Actions
Copy link

Status

  • ❌ No modified files found in the types directory.
    Please make sure to include types for any changes you have made. Thank you!.

@beatfactor beatfactor merged commit e193d19 into nightwatchjs:main Jan 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beatfactor beatfactor Awaiting requested review from beatfactor

@AutomatedTester AutomatedTester Awaiting requested review from AutomatedTester

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to fetch elements with reference to a shadow root.
2 participants
@garg3133 @beatfactor