Tweak when CDP connection is reset. #3994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Status
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CDP connections are currently reset after a session has finished, but this doesn't always work, like in the case of Selenium, which has its own implementation of
this.transport.sessionFinishedand hencecdp.resetConnection()is never called.So, instead of resetting the CDP connection after a session has finished, this PR moves that function call to when a new session is created, which is much more reliable, as whenever we get a new browser session, that's when we'd need a new CDP connection for that session.
Also, even in a single browser session, calling
.registerBasicAuth()requires a new CDP connection to be created every time, otherwise the basic auth credentials are never registered. This PR fixes that as well.Fixes: #3990.