deps: Update piscina
dependency to v4.3.1
.
#4020
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Piscina dependency to the latest version (
v4.3.1
) partially solves issue #4009 in that the main process no longer exits completely without showing any error in case ofuncaughtException
orunhandledRejection
in one of the worker threads. Instead, any such error in worker threads is handled properly now, thanks to piscinajs/piscina#361, and the error message appears in the console output of the affected test suites.But there are still two issues remaining to be resolved for such cases:
unhandledRejection
oruncaughtException
, the browser session is not closed properly and the browser window remains open while the test run exits. This happens in both serial and parallel mode of execution.