Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aliases for findAll #4089

Closed
wants to merge 1 commit into from

Conversation

Jai0401
Copy link

@Jai0401 Jai0401 commented Mar 4, 2024

fixes: #4057
Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

All commands(getAll & findElements) works perfectly with Nightwatch's example test.

@garg3133
Copy link
Member

browser.element.getAll() and browser.element.findElements() still don't work after this PR, please test and verify your changes before marking your PR as ready for review.

@garg3133 garg3133 marked this pull request as draft March 17, 2024 19:19
@garg3133
Copy link
Member

Fixed in #4130, thanks!

@garg3133 garg3133 closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add aliases for find() and findAll() command in new Element API
2 participants