Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed wrong example from getText() #4104

Closed

Conversation

dikwickley
Copy link
Contributor

@dikwickley dikwickley commented Mar 8, 2024

Fixes: #4103

@reallymello

Upon investigation, it does seem the non-awaited command doesn't work.
Screenshot 2024-03-08 at 5 24 21 PM

This is because the method used for getText in method-maping.js is getElementText, which is an async function.

async getElementText(id) {
const element = this.getWebElement(id);
const elementText = await element.getText();
return elementText;
},

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

Copy link

github-actions bot commented Mar 8, 2024

Status

  • ❌ No modified files found in the types directory.
    Please make sure to include types for any changes you have made. Thank you!.

@garg3133
Copy link
Member

garg3133 commented Mar 8, 2024

@dikwickley Thanks for the PR but the example will be fixed by #4043. It is one of the features in Nightwatch that despite the commands being asynchronous themselves, they can still be used in tests in a synchronous fashion.

Closing this one.

@garg3133 garg3133 closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.getText() documentation syntax error in example
2 participants