Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .check and .uncheck commands for immutable checkbox operations #4232

Merged

Conversation

reallymello
Copy link
Contributor

@reallymello reallymello commented Jul 6, 2024

This will add the .check and .uncheck commands for changing the checked/selected state of toggleable input elements like checkboxes to checked or unchecked taking into account their current checked/selected state (e.g. .check() won't click an already checked checkbox input, .uncheck() won't click an unchecked input).

This is a useful feature so that users don't have to first check the current checked/selected state of the element before issuing the click command (or not) to alter the checked state. Additionally, its less error-prone and more easily conveys the intention versus issuing the check command.

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • Before marking your PR for review, please test and verify your changes by making appropriate modifications to any of the Nightwatch example tests (present in examples/tests directory of the project) and running them. ecosia.js and duckDuckGo.js are good examples to work with.
  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

@AutomatedTester AutomatedTester merged commit c31582e into nightwatchjs:main Jul 17, 2024
17 checks passed
dikwickley pushed a commit to dikwickley/nightwatch that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants