Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --localtime to command line options #130

Closed
wants to merge 2 commits into from

Conversation

killsto
Copy link

@killsto killsto commented Jul 18, 2013

This fixes issue #128

@nirvdrum
Copy link
Owner

Sorry I'm just getting to this. The proposed fix seems quite reasonable, but unfortunately has fallen out of date. If you wouldn't mind rebasing off master, that'd be very helpful. If you don't have the time or no longer need it, I'll do the rebase myself as time permits.

@andrasq
Copy link

andrasq commented Jan 23, 2015

I rebased it, see #185.

@edpbx
Copy link

edpbx commented Apr 17, 2015

@andrasq may I suggest closing this PR since it's now obsolete?

@andrasq
Copy link

andrasq commented Apr 26, 2015

obsolete how?

@nirvdrum
Copy link
Owner

Sorry, I completely missed the rebase update. I'll take a look and see what the current status is here.

@nirvdrum nirvdrum self-assigned this Apr 26, 2015
@edpbx
Copy link

edpbx commented Apr 27, 2015

@andrasq I mean that the functionality in this PR from you has merge conflicts and is available in your #185, so there is no reason to leave this PR open?

@andrasq
Copy link

andrasq commented Apr 27, 2015

@edpbx oh, right you are. #185 duplicates this, yes; this can be closed

@edpbx
Copy link

edpbx commented Apr 27, 2015

Great! I'm not an admin of this: could you click the "close"? :-)

@andrasq
Copy link

andrasq commented Apr 27, 2015

oh! I think you meant to ask @killsto, the author of #130. I, @andrasq, rebased (duplicated really) the feature in #185, but 130 isn't mine to close.

@killsto
Copy link
Author

killsto commented Apr 27, 2015

I forgot I did this! I will go ahead and close it.

@killsto killsto closed this Apr 27, 2015
@edpbx
Copy link

edpbx commented Apr 28, 2015

👍

@jacobwwang
Copy link

@andrasq
I run svn2git --localtime --rebase, based on => https://github.com/andrasq/svn2git
But the timestamp still is Date: Thu Jun 8 04:50:40 2017 +0000
How can i fix it
Thanks

@andrasq
Copy link

andrasq commented Jun 9, 2017

what is your local computer timezone? The --localtime option is just passed
to git svn fetch --localtime, which I think prevents the svn commit timestamps
from getting converted to GMT. I don't know what happens if the svn timestamps
themselves are GMT; our repos had localtime svn commit times.

@jacobwwang
Copy link

@andrasq
Thanks for your reply.
Both local computer timezone and svn commit timestamp are 'China Standard Time UT+8:00'.

It can correctly convert timestamp when I use svn2git svn_url --localtime to create a git repo.

But I use svn2git --rebase --localtime to pull in the latest changes from SVN into my git repo created from above, it doesn't work. the timestamp of commit still is GMT+0000.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants