Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests across backend package #13

Open
nitishm opened this issue Jan 22, 2019 · 4 comments
Open

Add unit tests across backend package #13

nitishm opened this issue Jan 22, 2019 · 4 comments

Comments

@nitishm
Copy link
Owner

nitishm commented Jan 22, 2019

Need to add unit tests for the backend server to test all the attack options plus all the additional logic in the internal/vegeta/attack.go, internal/vegeta/report.go and internal/vegeta/store.go among the other files and packages.

@andrysds
Copy link
Contributor

andrysds commented Feb 3, 2019

@nitishm I'll try to work on this issue.

@nitishm
Copy link
Owner Author

nitishm commented Feb 3, 2019

Awesome !!!

@nitishm
Copy link
Owner Author

nitishm commented Feb 11, 2019

@andrysds Heads up. I have changed the entire implementation from go-swagger to gin-gonic. Most, if not all, of the backend code has been refactored. With the new structure it should be much easier to add dependency mocks for unit tests.

Let me know if you are still interested in working this issue.

@nitishm
Copy link
Owner Author

nitishm commented Feb 17, 2019

NOTE: Unit tests should use mockery/testify to create mock interface implementations.

nitishm pushed a commit that referenced this issue Mar 2, 2019
- Added query filter for attack status
- Added more UT coverage
nitishm added a commit that referenced this issue Mar 2, 2019
- Added query filter for attack status
- Added more UT coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants