Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use --check-cfg to validate cfg attributes during automated builds #1734

Closed
rtzoeller opened this issue Jun 6, 2022 · 1 comment
Closed

Use --check-cfg to validate cfg attributes during automated builds #1734

rtzoeller opened this issue Jun 6, 2022 · 1 comment

Comments

@rtzoeller
Copy link
Collaborator

Consider enabling some form of the --check-cfg flag during automated builds, to catch typos.

rust-lang/cargo#10554
@rtzoeller rtzoeller mentioned this issue Jun 6, 2022
Merged
bors bot added a commit that referenced this issue Jun 9, 2022
@bors @rtzoeller
Merge #1735
32d597b 
1735: Cleanup cfg blocks r=asomers a=rtzoeller

Remove obsolete references to target_env = wasi, target_os = nacl, target_os = osx, and a typo'd target_os = fushsia that didn't compile when fixed.

 - target_env = wasi is dead: rust-lang/rust#60117
 - target_os = nacl is dead: rust-lang/rust#45041
 - target_os = osx is dead, but I can't find a link.

Found while exploring `--check-cfg`, as mentioned in #1734.

Co-authored-by: Ryan Zoeller <rtzoeller@rtzoeller.com>
@SteveLauC SteveLauC mentioned this issue Jan 15, 2024
Closed
@SteveLauC
Copy link
Member

#2293 is a duplicate of this issue, but I am going to close this one as the new one has more information and is up-to-date with the current Nix status:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rtzoeller @SteveLauC