Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make crate libc import public. #284

Merged
merged 1 commit into from
Feb 29, 2016
Merged

Make crate libc import public. #284

merged 1 commit into from
Feb 29, 2016

Conversation

fiveop
Copy link
Contributor

@fiveop fiveop commented Feb 28, 2016

On currently nightly I got an error regarding the public export of libc in sys::ioctl. It now requires us to import the extern crate publicly.

@kamalmarhubi
Copy link
Member

I don't fully understand the implications of this. Seems related to #226?

@posborne
Copy link
Member

II'm OK with this change and I don't see another way to solve the problem while keeping the ioctl stuff the way it is now (using macros).

@fiveop
Copy link
Contributor Author

fiveop commented Feb 29, 2016

The other option is not exporting libc from ioctl and apparently that breaks things.

@posborne
Copy link
Member

Yet another option would be to change the nix::sys::ioctl to use functions that are part of the nix API rather than generating code that directly uses libc. I am somewhat partial to this solution and maybe eliminating the macros completely.

Then again, I'm not sure how many users are depending on the macros. I think they were an interesting experiment but I'm not sure they really make sense in nix and certainly seem to clash with the other exposed APIs to some degree.

@fiveop
Copy link
Contributor Author

fiveop commented Feb 29, 2016

For now, I'd like to get the build working again.

For the discussion on whether to export libc or not we already have #226.

@posborne
Copy link
Member

Fair enough, @homu r+

@homu
Copy link
Contributor

homu commented Feb 29, 2016

📌 Commit 37a2884 has been approved by posborne

@homu
Copy link
Contributor

homu commented Feb 29, 2016

⌛ Testing commit 37a2884 with merge e0f5444...

homu added a commit that referenced this pull request Feb 29, 2016
Make crate libc import public.

On currently nightly I got an error regarding the public export of libc in sys::ioctl. It now requires us to import the extern crate publicly.
@homu
Copy link
Contributor

homu commented Feb 29, 2016

☀️ Test successful - status

@homu homu merged commit 37a2884 into nix-rust:master Feb 29, 2016
@fiveop fiveop deleted the fix_build branch May 1, 2016 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants