Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eventfd: Follow nix conventions #383

Merged
merged 1 commit into from
Jul 4, 2016
Merged

Conversation

kamalmarhubi
Copy link
Member

This commit revamps to eventfd to follow nix conventions:

  • drop in-crate FFI definitions
  • rename EventFdFlag to EfdFlags

Additionally, it changes the initval argument to be a libc::c_uint,
matching the actual type.

This commit revamps to eventfd to follow nix conventions:
  - drop in-crate FFI definitions
  - rename EventFdFlag to EfdFlags

Additionally, it changes the initval argument to be a libc::c_uint,
matching the actual type.
@posborne
Copy link
Member

posborne commented Jul 4, 2016

Looks good to me. @homu r+

@homu
Copy link
Contributor

homu commented Jul 4, 2016

📌 Commit c9d92f1 has been approved by posborne

@homu
Copy link
Contributor

homu commented Jul 4, 2016

⚡ Test exempted - status

@homu homu merged commit c9d92f1 into nix-rust:master Jul 4, 2016
homu added a commit that referenced this pull request Jul 4, 2016
eventfd: Follow nix conventions

This commit revamps to eventfd to follow nix conventions:
  - drop in-crate FFI definitions
  - rename EventFdFlag to EfdFlags

Additionally, it changes the initval argument to be a libc::c_uint,
matching the actual type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants