Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a getter for grad P #135

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add a getter for grad P #135

wants to merge 4 commits into from

Conversation

Sbte
Copy link
Member

@Sbte Sbte commented May 2, 2022

No description provided.

@Sbte Sbte requested a review from ipelupessy May 2, 2022 12:05
@Sbte
Copy link
Member Author

Sbte commented May 3, 2022

@ipelupessy Please check if the last commit is what you need. The rest is some cleanup I thought I needed for gradp, but then decided that I may as well compute the vector itself on the fortran side instead.

@ipelupessy
Copy link
Contributor

so ocean->getGradP('V') gets you a vector similar to state ith the gradPx and gradPy in 1st and second place (of 6)?

@Sbte
Copy link
Member Author

Sbte commented May 3, 2022

Yes, or ocean->getGradP('C') if you want a copy. And Pz is also in there.

@ipelupessy
Copy link
Contributor

I dunno if there is an easy way to do this, but as test I would try to fill up the state with linear ramps in both directions to see whether the resulting grads are constant...

@ipelupessy
Copy link
Contributor

the estimate is checkerboard free?

@Sbte
Copy link
Member Author

Sbte commented May 3, 2022

Yes, we discussed this at the meeting

@Sbte
Copy link
Member Author

Sbte commented May 6, 2022

@ipelupessy The suggestion for that test was very useful. I added it and fixed the implementation accordingly.

@Sbte Sbte force-pushed the master branch 2 times, most recently from 6d74f96 to 3d33a13 Compare May 24, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants