Make basic_json allocate-aware, as mentioned in #161 + unrelated changes for #164 #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to make it work with nlohmann#164. The thing is that the current code attempts to define containers with incomplete types, this is not supported by the standard and does not work unordered_map. std::vector and std::map work but we might be in the realm of undefined behavior.
|
@palacaze Sorry for not coming back to this PR earlier. There were quite some fixes on the MSVC side, so I would like to ask you to resubmit the PR to work on the latest version. |
|
Unfortunately, this PR staled - allocators are hard. :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to make it work with #164.
The thing is that the current code attempts to define containers with incomplete types,
this is not supported by the standard and does not work with unordered_map. std::vector and
std::map work but we might be in the realm of undefined behaviour.