Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel: Improve support for bzlmod #4111

Closed
wants to merge 1 commit into from
Closed

Bazel: Improve support for bzlmod #4111

wants to merge 1 commit into from

Conversation

Vertexwahn
Copy link
Contributor

The Bazel build system now supports a new way of handling 3rd party dependencies, such as JSON for Modern C++. For this new way, a MODULE.bazel file is needed - in the long term, the WORKSPACE.bazel file will not be needed anymore and will be deleted in the future.

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same when pulling 55e16a4 on Vertexwahn:bazel-support into 5d27543 on nlohmann:develop.

@nlohmann
Copy link
Owner

nlohmann commented Sep 2, 2023

Do I really need to add more files just to support Bazel?

@Vertexwahn
Copy link
Contributor Author

@nlohmann In the long term MODULE.bazel will replace the WORKSPACE.bazel file. Maybe its to early for this switch. If you do not want to have more Bazel files in your repo we can simply close this PR and I will do the replacement of WORKSPACE.bazel by MODULE.bazel when this is the main way of Bazel to handle 3rd party deps...

@nlohmann
Copy link
Owner

@nlohmann In the long term MODULE.bazel will replace the WORKSPACE.bazel file. Maybe its to early for this switch. If you do not want to have more Bazel files in your repo we can simply close this PR and I will do the replacement of WORKSPACE.bazel by MODULE.bazel when this is the main way of Bazel to handle 3rd party deps...

Ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants