Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore the original style of the in-game music title animation #55

Open
nmlgc opened this issue Dec 23, 2023 · 1 comment
Open

Restore the original style of the in-game music title animation #55

nmlgc opened this issue Dec 23, 2023 · 1 comment
Labels
BGM Bug Something isn't working Modding ~≤0.33 pushes Projected number of pushes needed. Might turn out to get more expensive!

Comments

@nmlgc
Copy link
Owner

nmlgc commented Dec 23, 2023 •
edited
Loading

#9 will allow modded BGM titles to span the entire playfield, but the resulting animations are much too short, cutting off way before they're supposed to end:

55.webm

Fixing this will probably require deeper research into how this animation works.
@nmlgc nmlgc added Bug Something isn't working BGM Modding ~≤0.33 pushes Projected number of pushes needed. Might turn out to get more expensive! labels Dec 23, 2023
@nmlgc nmlgc changed the title Fix in-game music title animation for long BGM titles Restore the original style of the in-game music title animation Mar 4, 2024
@nmlgc
Copy link
Owner Author

nmlgc commented Mar 4, 2024

Animations for short titles also won't look as good in the P0275 build as they did in the original game. Might be the same or a similar underlying issue.

P0275:

2024-02-04-SH01-Ingame-music-title-P0275.webm

Original game:

2024-02-04-SH01-Ingame-music-title-original.webm

nmlgc added a commit that referenced this issue Mar 9, 2024
@nmlgc
[Effects] [Bug] Music title: Consistently right-align based on render…
3de48ab 
…ed width

Unfortunately has a significant effect on the animation, especially for
shorter titles, but maintains consistency with the obviously
whitespace-trimmed title tags in the upcoming BGM mod packs. Let's fix
that animation later, in #55.

Completes P0272, funded by Ember2528.
nmlgc added a commit that referenced this issue Mar 9, 2024
@nmlgc
[Effects] Music title: Allow titles to span the entire playfield
a069403 
Right now, long titles will cause the animation to cut off, but this is
much better than restricting their width. Let's open #55 and fix the
animation bug some other time.

Part of P0273, funded by Ember2528.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BGM Bug Something isn't working Modding ~≤0.33 pushes Projected number of pushes needed. Might turn out to get more expensive!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nmlgc