Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support comments from BGM pack file metadata #56

Open
nmlgc opened this issue Dec 27, 2023 · 0 comments
Open

Support comments from BGM pack file metadata #56

nmlgc opened this issue Dec 27, 2023 · 0 comments
Labels
Enhancement New feature or request Localization Modding

Comments

@nmlgc
Copy link
Owner

nmlgc commented Dec 27, 2023 •
edited
Loading

The initial version of #9 will show an empty music comment for any modded BGM file that is not linked to a MIDI from the original MUSIC.DAT. Fixing this would mostly be nice for the BGM packs of the arranged soundtrack, but it would also be nice for BGM mods in general.

Since some of ZUN's comments for the arranged soundtrack are pretty long, this will at least require adding vertical scrolling to the Music Room comment display. Which in turn implies automatic line breaks, which in turn depends on the solution for text shaping that will be developed for #39.
@nmlgc nmlgc added Enhancement New feature or request Modding Localization labels Dec 27, 2023
nmlgc added a commit that referenced this issue Mar 9, 2024
@nmlgc
[Music Room] Only show comments if the track loaded an original MIDI
275fb71 
Proper support for comments from BGM pack file metadata will have to
wait until #56.

Part of P0274, funded by Ember2528.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request Localization Modding
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nmlgc