Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move core types to extra package #254

Merged
merged 17 commits into from
Aug 28, 2024

Conversation

jkoenig134
Copy link
Member

@jkoenig134 jkoenig134 commented Aug 28, 2024

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

Description / Motivation

As the Core* types were placed in transport before we could not re-use them in e.g. the connector sdk. With an extra package that transport and content can depend on we now have the ability to re-use content types.

@jkoenig134 jkoenig134 added the refactoring Refactoring of code label Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 80.84465% with 127 lines in your changes missing coverage. Please review.

Files Patch % Lines
...ssors/utility/validateAttributeMatchesWithQuery.ts 6.06% 31 Missing ⚠️
...ion/src/modules/attributes/AttributesController.ts 51.72% 28 Missing ⚠️
packages/core-types/src/CoreId.ts 65.00% 14 Missing ⚠️
...uests/incoming/DecideRequestParametersValidator.ts 20.00% 8 Missing ⚠️
...on/src/modules/attributes/local/QueryTranslator.ts 14.28% 6 Missing ⚠️
packages/transport/src/core/types/CoreHash.ts 57.14% 6 Missing ⚠️
...ion/src/modules/attributes/local/LocalAttribute.ts 42.85% 4 Missing ⚠️
packages/transport/src/core/Transport.ts 25.00% 3 Missing ⚠️
...modules/accounts/data/IdentitySecretCredentials.ts 0.00% 3 Missing ⚠️
...port/src/modules/challenges/ChallengeController.ts 40.00% 3 Missing ⚠️
... and 15 more
Files Coverage Δ
packages/app-runtime/src/AppRuntime.ts 78.16% <100.00%> (+0.06%) ⬆️
packages/app-runtime/src/AppStringProcessor.ts 44.29% <100.00%> (+0.37%) ⬆️
...es/app-runtime/src/multiAccount/AccountServices.ts 95.74% <100.00%> (ø)
...runtime/src/multiAccount/MultiAccountController.ts 79.46% <100.00%> (-0.68%) ⬇️
.../app-runtime/src/multiAccount/data/LocalAccount.ts 100.00% <100.00%> (ø)
...ption/src/consumption/ConsumptionBaseController.ts 93.54% <100.00%> (+0.21%) ⬆️
...nsumption/src/consumption/ConsumptionController.ts 96.55% <100.00%> (+0.01%) ⬆️
...nsumption/src/consumption/ConsumptionCoreErrors.ts 79.88% <100.00%> (ø)
packages/consumption/src/index.ts 100.00% <100.00%> (ø)
...attributeListeners/AttributeListenersController.ts 96.96% <100.00%> (+0.04%) ⬆️
... and 210 more

... and 47 files with indirect coverage changes

Copy link
Contributor

@Milena-Czierlinski Milena-Czierlinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the (app-)runtime tsconfig files need "references": [{ "path": "../core-types" }] as well?

@jkoenig134
Copy link
Member Author

No, things are already referenced in library below.

@jkoenig134 jkoenig134 merged commit 15d3e6a into main Aug 28, 2024
17 checks passed
@jkoenig134 jkoenig134 deleted the refactore/move-core-types-to-extra-package branch August 28, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants