Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upsert settings #261

Merged
merged 5 commits into from
Sep 2, 2024
Merged

Upsert settings #261

merged 5 commits into from
Sep 2, 2024

Conversation

jkoenig134
Copy link
Member

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@jkoenig134 jkoenig134 added the enhancement New feature or request label Sep 2, 2024
@jkoenig134 jkoenig134 marked this pull request as ready for review September 2, 2024 12:58
@codecov Codecov
Copy link

codecov bot commented Sep 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...xtensibility/facades/consumption/SettingsFacade.ts 100.00% <100.00%> (ø)
packages/runtime/src/useCases/common/Schemas.ts 100.00% <100.00%> (ø)
...seCases/consumption/settings/UpsertSettingByKey.ts 100.00% <100.00%> (ø)
...runtime/src/useCases/consumption/settings/index.ts 100.00% <100.00%> (ø)

@Milena-Czierlinski
Copy link
Contributor

Just out of interest, what is the motivation behind implementing this feature right now?

@jkoenig134
Copy link
Member Author

jkoenig134 commented Sep 2, 2024 •
edited
Loading

@Milena-Czierlinski the app needs it :)

@jkoenig134 jkoenig134 merged commit 00d2bba into main Sep 2, 2024
17 checks passed
@jkoenig134 jkoenig134 deleted the upsert-settings branch September 2, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Milena-Czierlinski Milena-Czierlinski Milena-Czierlinski approved these changes

@sebbi08 sebbi08 Awaiting requested review from sebbi08

@britsta britsta Awaiting requested review from britsta

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkoenig134 @Milena-Czierlinski