Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply code and message to RejectResponseItem #267

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Apply code and message to RejectResponseItem #267

merged 1 commit into from
Sep 11, 2024

Conversation

Milena-Czierlinski
Copy link
Contributor

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@Milena-Czierlinski Milena-Czierlinski added the bug Something isn't working label Sep 11, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...ests/itemProcessors/GenericRequestItemProcessor.ts 95.74% <100.00%> (ø)

@Milena-Czierlinski Milena-Czierlinski marked this pull request as ready for review September 11, 2024 09:28
jkoenig134
jkoenig134 approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch!

@Milena-Czierlinski Milena-Czierlinski merged commit e6aebf7 into main Sep 11, 2024
19 checks passed
@Milena-Czierlinski Milena-Czierlinski deleted the fix/apply-code-and-message-to-rejectresponseitem branch September 11, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoenig134 jkoenig134 jkoenig134 approved these changes

@britsta britsta Awaiting requested review from britsta

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Milena-Czierlinski @jkoenig134