Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrypting Messages fails when Relationship is not active anymore #279

Merged
merged 11 commits into from
Sep 23, 2024

Conversation

Magnus-Kuhn
Copy link
Contributor

@Magnus-Kuhn Magnus-Kuhn commented Sep 20, 2024

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ransport/src/modules/messages/MessageController.ts 50.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
...ransport/src/modules/messages/MessageController.ts 87.94% <50.00%> (+3.95%) ⬆️

... and 1 file with indirect coverage changes

@Magnus-Kuhn Magnus-Kuhn changed the title validate messages, challenges for once active relationship Sending and validating Relationship Challenges and decrypting Messages is possible if Relationship was once active Sep 20, 2024
@Magnus-Kuhn Magnus-Kuhn added the bug Something isn't working label Sep 20, 2024
@Magnus-Kuhn
Copy link
Contributor Author

Magnus-Kuhn commented Sep 20, 2024

I'm not sure about how much sense it makes to create a relationship challenge after the relationship has been terminated - but then sending or requesting challenges via Messages is not supported, so you are supposed to use a side-channel for which termination doesn't matter?? idk

When I restricted it during the relationship termination implementation, I didn't understand how those challenges work

@jkoenig134
Copy link
Member

I'm not sure about how much sense it makes to create a relationship challenge after the relationship has been terminated

IMO it doesn't

@Magnus-Kuhn Magnus-Kuhn changed the title Sending and validating Relationship Challenges and decrypting Messages is possible if Relationship was once active Validating Relationship Challenges and decrypting Messages is possible if Relationship was once active Sep 20, 2024
@Magnus-Kuhn Magnus-Kuhn marked this pull request as ready for review September 20, 2024 12:23
@jkoenig134 jkoenig134 changed the title Validating Relationship Challenges and decrypting Messages is possible if Relationship was once active Decrypting Messages fails when Relationship is not active anymore Sep 20, 2024
@jkoenig134
Copy link
Member

@Magnus-Kuhn please always assign everyone available from the runtime team.

Magnus-Kuhn and others added 2 commits September 20, 2024 14:41
Co-authored-by: Julian König <33655937+jkoenig134@users.noreply.github.com>
@jkoenig134 jkoenig134 changed the title Decrypting Messages fails when Relationship is not active anymore Decrypting Messages and verifying Challanges fails when Relationship is not active anymore Sep 20, 2024
@Magnus-Kuhn Magnus-Kuhn changed the title Decrypting Messages and verifying Challanges fails when Relationship is not active anymore Decrypting Messages fails when Relationship is not active anymore Sep 23, 2024
@Magnus-Kuhn Magnus-Kuhn enabled auto-merge (squash) September 23, 2024 13:44
@Magnus-Kuhn Magnus-Kuhn merged commit 85db57a into main Sep 23, 2024
17 checks passed
@Magnus-Kuhn Magnus-Kuhn deleted the decryption-after-relationship-termination branch September 23, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants