-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decrypting Messages fails when Relationship is not active anymore #279
Conversation
Codecov ReportAttention: Patch coverage is
|
I'm not sure about how much sense it makes to create a relationship challenge after the relationship has been terminated - but then sending or requesting challenges via Messages is not supported, so you are supposed to use a side-channel for which termination doesn't matter?? idk When I restricted it during the relationship termination implementation, I didn't understand how those challenges work |
IMO it doesn't |
packages/transport/src/modules/challenges/ChallengeController.ts
Outdated
Show resolved
Hide resolved
packages/transport/src/modules/relationships/RelationshipsController.ts
Outdated
Show resolved
Hide resolved
packages/transport/test/modules/messages/MessageController.test.ts
Outdated
Show resolved
Hide resolved
@Magnus-Kuhn please always assign everyone available from the runtime team. |
Co-authored-by: Julian König <33655937+jkoenig134@users.noreply.github.com>
Readiness checklist