New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: impl the new Agent extend http.Agent #69

Merged

fengmk2 merged 3 commits into master from dont-patch-agent

Oct 22, 2018

Member

fengmk2 commented Oct 20, 2018

This is a BREAKING change.

Don't use patch mode anymore.
Improve code coverage to 100%.


          feat: impl the new Agent extend http.Agent

c4fbb0f

This is a BREAKING change.

Don't use patch mode anymore.
Improve code coverage to 100%.

fengmk2 added the enhancement label

fengmk2 requested a review from dead-horse

October 20, 2018 16:15

codecov bot commented Oct 20, 2018 •

edited

Loading

Codecov Report

Merging #69 into master will increase coverage by 8.48%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master    #69      +/-   ##
========================================
+ Coverage   91.51%   100%   +8.48%     
========================================
  Files           4      4              
  Lines         283    176     -107     
========================================
- Hits          259    176      -83     
+ Misses         24      0      -24

Impacted Files	Coverage Δ
lib/constants.js	`100% <100%> (ø)`
lib/agent.js	`100% <100%> (+5%)`	⬆️
lib/https_agent.js	`100% <100%> (ø)`	⬆️
index.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b81362...4089edd. Read the comment docs.

fengmk2 commented

View reviewed changes

lib/agent.js

+                }
+                [INIT_SOCKET](socket, options) {
+                  // bugfix here.

Member Author

fengmk2 Oct 20, 2018

又可以修复 node 的 bug 了。


          bugfix: support agent.options.timeout on https agent

c7b1358

https on node 8, 10 won't set agent.options.timeout by default

fengmk2 force-pushed the dont-patch-agent branch from 1748b6d to c7b1358 Compare

October 20, 2018 17:19

This was referenced Oct 20, 2018

async createCollection() #31

Closed

agent keepalive flow #7

Closed


          chore: move LICENSE from readme to file

4089edd

Member Author

fengmk2 commented Oct 21, 2018

I will merge today and use on npm.taobao.org for a week stable tests.

dead-horse reviewed

View reviewed changes

lib/agent.js

                   if (options.timeout === undefined) {
-                    options.timeout = options.freeSocketKeepAliveTimeout * 2;
+                    options.timeout = options.freeSocketTimeout * 2;

Member

dead-horse Oct 22, 2018

options.timeout = Math.max(options.freeSocketTimeout * 2, 30000);

dead-horse reviewed

View reviewed changes

lib/agent.js

                   if (options.timeout === undefined) {
-                    options.timeout = options.freeSocketKeepAliveTimeout * 2;
+                    options.timeout = options.freeSocketTimeout * 2;

Member

dead-horse Oct 22, 2018

options.timeout = Math.max(options.freeSocketTimeout * 2, 30000);

dead-horse reviewed

View reviewed changes

lib/agent.js

                   if (options.timeout === undefined) {
-                    options.timeout = options.freeSocketKeepAliveTimeout * 2;
+                    options.timeout = options.freeSocketTimeout * 2;

Member

dead-horse Oct 22, 2018

options.timeout = Math.max(options.freeSocketTimeout * 2, 30000);

dead-horse reviewed

View reviewed changes

lib/agent.js

                   if (options.timeout === undefined) {
-                    options.timeout = options.freeSocketKeepAliveTimeout * 2;
+                    options.timeout = options.freeSocketTimeout * 2;

Member

dead-horse Oct 22, 2018

options.timeout = Math.max(options.freeSocketTimeout * 2, 30000);

dead-horse reviewed

View reviewed changes

lib/agent.js

                   if (options.timeout === undefined) {
-                    options.timeout = options.freeSocketKeepAliveTimeout * 2;
+                    options.timeout = options.freeSocketTimeout * 2;

Member

dead-horse Oct 22, 2018

options.timeout = Math.max(options.freeSocketTimeout * 2, 30000);

dead-horse reviewed

View reviewed changes

lib/agent.js

                   if (options.timeout === undefined) {
-                    options.timeout = options.freeSocketKeepAliveTimeout * 2;
+                    options.timeout = options.freeSocketTimeout * 2;

Member

dead-horse Oct 22, 2018

options.timeout = Math.max(options.freeSocketTimeout * 2, 30000);

lib/agent.js

                   if (options.timeout === undefined) {
-                    options.timeout = options.freeSocketKeepAliveTimeout * 2;
+                    options.timeout = options.freeSocketTimeout * 2;

Member

dead-horse Oct 22, 2018

options.timeout = Math.max(options.freeSocketTimeout * 2, 30000);

lib/agent.js

                   if (options.timeout === undefined) {
-                    options.timeout = options.freeSocketKeepAliveTimeout * 2;
+                    options.timeout = options.freeSocketTimeout * 2;

Member

dead-horse Oct 22, 2018

options.timeout = Math.max(options.freeSocketTimeout * 2, 30000);

fengmk2 merged commit 498c8f1 into master

Member Author

fengmk2 commented Oct 22, 2018

竟然合并了才看的评论，我再提交一下。

fengmk2 deleted the dont-patch-agent branch

October 22, 2018 13:05

Member Author

fengmk2 commented Oct 22, 2018

4.0.0

Member

dead-horse commented Oct 22, 2018

白天评论发不出来..

skeggse commented Nov 13, 2019

What is the breaking change introduced in this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels