feat: only use server listen to detect port #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use npm scripts instead of Makefile
|
@xudafeng 原来的实现太复杂了，只需要 server listen 即可，不需要客户端 connect |
fengmk2
commented
Jan 17, 2017
| loop(port); | ||
| server.on('error', err => { | ||
| debug('listen %s error: %s', port, err); | ||
| port = 0; |
There was a problem hiding this comment.
失败一次之后马上监听随机端口，确保操作系统分配成功。
atian25
reviewed
Jan 17, 2017
| return promise; | ||
| } | ||
| }; | ||
| server.listen({ port }, () => { |
|
@fengmk2 👍 |
|
@xudafeng 发一个 minor 版本 |
|
done |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use npm scripts instead of Makefile