fix: fix undefined search params of get method #436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengmk2
reviewed
Feb 24, 2023
| @@ -405,9 +406,10 @@ export class HttpClient extends EventEmitter { | |||
| || isReadable(args.data); | |||
| if (isGETOrHEAD) { | |||
| if (!isStringOrBufferOrReadable) { | |||
| for (const field in args.data) { | |||
There was a problem hiding this comment.
只过滤 undefined 吧，其他还是按照 URL SearchParams 默认逻辑来， querystring 模块不是标准的规范。
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 8 8
Lines 1222 1224 +2
Branches 233 233
=======================================
+ Hits 1218 1220 +2
Misses 4 4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
还是保持 URL SearchParams 的逻辑 |
fengmk2
added a commit
that referenced
this pull request
Mar 25, 2023
fengmk2
added a commit
that referenced
this pull request
Mar 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix this
