Fix inability to get version from package.json #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`require('./package')` alone fails in some cases (i.e. Node versions), because that's not a valid package. Specifying the file ending fixes this issue and should be version independant. For reference and possible other ways of obtaining the version from code: https://stackoverflow.com/questions/9153571/is-there-a-way-to-get-version-from-package-json-in-nodejs-code
|
What's an example of a version of Node where this fails? We only support the latest LTS release and newer, currently Node 14. |
|
I have in fact noticed that it is not an issue with Node, but rather when using webpack to compress/bundle the code for deployment. Tested with webpack version |
markstos
approved these changes
Apr 19, 2022
|
Thank you! |
|
Thanks. Release today in v2.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
require('./package')alone fails in some cases (i.e. Node versions), because that's not a valid package. Specifying the file ending fixes this issue and should be version independant. For reference and possible other ways of obtaining the version from code: https://stackoverflow.com/questions/9153571/is-there-a-way-to-get-version-from-package-json-in-nodejs-code