Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove prototype suffix from authenticated athlete endpoint #141

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

tcoyze
Copy link
Contributor

@tcoyze tcoyze commented Jun 20, 2023

Oddly the athlete.prototype endpoint works, but could break in the future so I opted to change it.

@markstos
Copy link
Collaborator

Did you check the blame history to see if there might be a reason where athlete.prototype was used here before?

@tcoyze
Copy link
Contributor Author

tcoyze commented Jul 20, 2023

Did you check the blame history to see if there might be a reason where athlete.prototype was used here before?

Thanks for the suggestion and following up with me! I did take a look at the commit that made the change from athlete to athlete.prototype. The change seemed to be made in error. If you look at the request that's sent over the wire it is going to https://www.strava.com/api/v3/athlete.prototype which is undocumented. If you replace athlete.prototype with athlete.umbrella, or athlete.theboz they both return the data of the authenticated athelete. My change is just to keep in line with the documentation in the event that Strava fixes / changes this behavior.

@markstos markstos merged commit fb3a7cc into node-strava:main Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants