Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all locals and parameter names to snake_case #193

Merged
merged 5 commits into from
Mar 23, 2017

Commits on Mar 23, 2017

  1. Convert all locals and parameter names to snake_case

    Standardize some parameter names across the N-API surface such as ```napi_env env``` and ```size_t length```. Make all the parameter names in the header match the cc file and expand some parameter names from single characters into meaningful words.
    
    Also addresses a couple of minor PR feedback items:
     - Rename ```napi_reference_addref``` and ```napi_reference_release``` to ```napi_reference_ref``` and ```napi_reference_unref``` (respectively)
     - Rename ```Reference::AddRef``` and ```Reference::Release``` to ```Reference::Ref``` and ```Reference::Unref``` (respectively)
     - Remove ```napi_create_boolean```, ```napi_get_true```, and ```napi_get_false``` and replace them with ```napi_get_boolean```
     - Rename ```napi_get_type_of_value``` to ```napi_typeof```
     - Add a ```result_data``` out parameter to ```napi_create_buffer_copy``` which returns the data pointer of the new buffer
     - Change ```napi_get_value_string_utf8``` and ```napi_get_value_string_utf16``` to accept a null output buffer and return the length of the source string in that case via the ```result``` parameter
     - Remove ```napi_get_value_string_utf8_length``` and ```napi_get_value_string_utf16_length``` due to the above
     - Change ```Reference``` ctor and dtor to be protected and added public ```static Reference* Reference::New``` and ```static void Reference::Delete``` methods to make it more clear how the ```Reference``` objects are allocated and cleaned-up
     - Add a type check to ``napi_get_array_length``` which returns an error if the argument is not an array object
     - Change ```napi_create_symbol``` to take a ```napi_value``` instead of a ```const char*``` for the symbol description string. The API now throws if description is not a string but NULL is allowed.
    boingoing committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    3894336 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    456e255 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8ccefe3 View commit details
    Browse the repository at this point in the history
  4. Fixes for unit tests

    boingoing committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    4e0ea3b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ed3344a View commit details
    Browse the repository at this point in the history